libnvme: Add accessor generation framework#2959
Closed
martin-belanger wants to merge 2 commits intolinux-nvme:masterfrom
Closed
libnvme: Add accessor generation framework#2959martin-belanger wants to merge 2 commits intolinux-nvme:masterfrom
martin-belanger wants to merge 2 commits intolinux-nvme:masterfrom
Conversation
added 2 commits
November 6, 2025 06:20
Explicitly add 'config_dep' to 'deps' to ensure that config.h is generated before building libnvme. When defining 'c_args', use the '-include' option directly instead of hiding it in 'config_h_arg'. This makes the meson.build file clearer. Since '-include' is used to include config.h, there is no need to add 'internal_incdir' to the include path via '-I' (i.e. with 'include_directories' argument). Note: using '-include' is the Meson-recommended way to include generated headers. The '-I' option (via 'include_directories') should be reserved for static headers. Signed-off-by: Martin Belanger <[email protected]>
This only adds the framework for code generation but leaves the actual generation disabled for now. Signed-off-by: Martin Belanger <[email protected]>
martin-belanger
changed the title
Author
|
@igaw - This is the new PR for the accessor generator. This only adds the framework. The actual code generation is currently disabled until we're ready for it. |
Author
|
Closing this outdated PR. A new PR is on the way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are two commits. In the first commit we do some meson.build clean up to prepare the environment for the code generation. The second commit adds the code generator framework, but leaves the actual code generation disabled for now.